Defs #267
Closed
Defs #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to latest
Straight up copy Draft 7 tests to Draft 2019-06.
Rename definitions to $defs in the 2019-06 draft.
Member
Author
|
Not sure why I've never had a PR on this repo pass tests... |
Member
|
That test is saying when you add a new remote file you also have to add it to that Python script at the minute (in the REMOTES object). |
Member
Author
|
Think I fixed it. Let's see 🤞 |
Member
|
To be fair it's an exceedingly unhelpful message :) Looks like yeah you're good now, but probably deserves improving... |
Member
|
@gregsdennis hopefully 12a62ba would have helped you. |
Member
|
OK, merged as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to update #266 based on the suggestions in that PR.