Use base syntax groups for templates boundaries #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to match GraphQL syntax inside of template strings, we recreate the JavaScript/TypeScript template string syntax regions and embed our syntax within them. These region's 'start' and 'end' patterns were therefore being matched using our syntax groups. Instead, use 'matchgroup=' to explicitly match the boundaries using the base syntax's groups. This better integrates with those filetype's natural syntax and indentation definitions while still giving us control over the embedded GraphQL syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to match GraphQL syntax inside of template strings, we recreate
the JavaScript/TypeScript template string syntax regions and embed our
syntax within them. These region's 'start' and 'end' patterns were
therefore being matched using our syntax groups.
Instead, use 'matchgroup=' to explicitly match the boundaries using the
base syntax's groups. This better integrates with those filetype's
natural syntax and indentation definitions while still giving us control
over the embedded GraphQL syntax.