This repository was archived by the owner on May 10, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Core Enhancement 3 - Merge Featured into Articles #11
Open
YatharthVyas
wants to merge
16
commits into
joomla-projects:dev
Choose a base branch
from
YatharthVyas:merge-article-featured
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Core Enhancement 3 - Merge Featured into Articles #11
YatharthVyas
wants to merge
16
commits into
joomla-projects:dev
from
YatharthVyas:merge-article-featured
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
About the menuItem "Featured Articles". Could we remove the link to featured articles from the backend? Or is it a b/c break ? Needs to be discussed |
Good Point. |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to track all the file changes and commits made. Mentors can review the changes and provide feedback.
I will update the description as and when I push more commits.
Plan Document: https://docs.google.com/document/d/1Pl8JGa2hkYkmJzQOn9_mS8a4imDmqc2a/edit#heading=h.t5tri5tytv7q
view=featured
Edit: Merge Table has been removed from the above list because I feel that both the files (in /src/Table/) play an essential role and they must be different
Summary of Changes
[A] New Selector Dropdown
A searchtools selector is added that can be used to toggle between:
[B] Model Merged
$featured
variable is used as a condition to manipulate the query to adjust to Featured[C] Templates Merged
state->get('featured')
to conditonally render the template code as per featured or not.[D] Views Merged
state->get('featured')
to conditonally render the toolbar options[E] Controller Merged
Testing Instructions
Expected result AFTER applying this Pull Request
Everything works normally