This seem to be interesting fixes, mind if we merge them #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't mind at all. This was the first time i contributed anything publicly so wasn't sure about creating a PR but I'd be happy to have it merged. |
|
@joustrich I'd say in general, just create the PR, happy to see the project move forward. Before this could be merged we need to fix the tests though. Are you willing to work on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @joustrich,
I was looking at the fork graph and noticed you did some work improving leaflet-headless. I'm not sure if you intentionally did not create a pull request, to me they are welcome, although I have limited time to work on leaflet-headless, it would be nice to keep it up to date.