- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.3k
Fix staging when using the new useExternalDiffGitConfig config #4895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix staging when using the new useExternalDiffGitConfig config #4895
Conversation
| Coverage summary from CodacySee diff coverage on Codacy
 Coverage variation details
 Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:  Diff coverage details
 Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:  See your quality gate settings Change summary preferencesFootnotes
 | 
| @stefanhaller This fixes it, thank you! | 
This new config was introduced in 0.55, but it didn't work in the staging view or custom patch building view.
f82f41d    to
    c35e377      
    Compare
  
    This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.55.0` -> `v0.55.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.55.1`](https://github.com/jesseduffield/lazygit/releases/tag/v0.55.1) [Compare Source](jesseduffield/lazygit@v0.55.0...v0.55.1) <!-- Release notes generated using configuration in .github/release.yml at v0.55.1 --> This hotfix release fixes two bugs that have crept in in v0.55.0: one is a regression that broke displaying the enter key in the keybindings menu, the other is a problem with a newly added feature that didn't work quite correctly. See below for details. For the changes in 0.55.0, see <https://github.com/jesseduffield/lazygit/releases/tag/v0.55.0>. #### What's Changed ##### Fixes 🔧 - Don't hide keybindings that match the confirmMenu key in the keybindings menu by [@​stefanhaller](https://github.com/stefanhaller) in [#​4880](jesseduffield/lazygit#4880) - Fix staging when using the new useExternalDiffGitConfig config by [@​stefanhaller](https://github.com/stefanhaller) in [#​4895](jesseduffield/lazygit#4895) **Full Changelog**: <jesseduffield/lazygit@v0.55.0...v0.55.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMTUuNiIsInVwZGF0ZWRJblZlciI6IjQxLjExNS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
…duffield#4895) This new config was introduced in 0.55, but it made it impossible to enter the staging view or custom patch building view. Fixes jesseduffield#4832 (comment).
This new config was introduced in 0.55, but it made it impossible to enter the staging view or custom patch building view.
Fixes #4832 (comment).