Update CONTRIBUTING.md to clarify translation contribution process
#4806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu08
commented
Aug 10, 2025
CONTRIBUTING.md
Outdated
|
|
||
| ### For Developers Adding New Text | ||
|
|
||
| If you need to render text to the user, you should add a new field to the TranslationSet struct in `pkg/i18n/english.go` and add the actual content within the `EnglishTranslationSet()` method in the same file. Then you can access via `gui.Tr.YourNewText` (or `self.c.Tr.YourNewText`, etc). |
There was a problem hiding this comment.
The content of this line is not modified from original one.
kyu08
commented
Aug 10, 2025
| ## Internationalisation | ||
|
|
||
| Boy that's a hard word to spell. Anyway, lazygit is translated into several languages within the pkg/i18n package. If you need to render text to the user, you should add a new field to the TranslationSet struct in `pkg/i18n/english.go` and add the actual content within the `EnglishTranslationSet()` method in the same file. Then you can access via `gui.Tr.YourNewText` (or `self.c.Tr.YourNewText`, etc). Although it is appreciated if you translate the text into other languages, it's not expected of you (google translate will likely do a bad job anyway!). | ||
| Boy that's a hard word to spell. Anyway, lazygit is translated into several languages within the pkg/i18n package. |
There was a problem hiding this comment.
The content of this line is not modified from original one.
stefanhaller
force-pushed
the
update-translation-contribution-document
branch
from
e5b1f7b to
f172cc4
Compare
stefanhaller
force-pushed
the
update-translation-contribution-document
branch
from
f172cc4 to
c4a684c
Compare
|
Thanks for the review and following up! |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 12, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.54.1` -> `v0.54.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.54.2`](https://github.com/jesseduffield/lazygit/releases/tag/v0.54.2) [Compare Source](jesseduffield/lazygit@v0.54.1...v0.54.2) <!-- Release notes generated using configuration in .github/release.yml at v0.54.2 --> Here's another point release; this one fixes a performance regression in 0.54.0 that made flicking through diffs a little less snappy (or a lot less, in some scenarios) than it could be. For the changes in 0.54.0, see https://github.com/jesseduffield/lazygit/releases/tag/v0.54.0. #### What's Changed ##### Fixes 🔧 - Fix scrollbar in certain popup panels (e.g. the intro message for new users) by [@​stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4804 - Fix delay with flicking through files or commits when git diff is very slow by [@​stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4803 ##### Maintenance ⚙️ - Stop bumping our homebrew formula by [@​stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4799 - Update the badges of golangci-lint and homebrew in `README.md` by [@​kyu08](https://github.com/kyu08) in jesseduffield/lazygit#4807 ##### Docs 📖 - Fix the useHunkModeInStagingView hint in the breaking changes message by [@​stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4800 - Update `CONTRIBUTING.md` to clarify translation contribution process by [@​kyu08](https://github.com/kyu08) in jesseduffield/lazygit#4806 **Full Changelog**: jesseduffield/lazygit@v0.54.1...v0.54.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
CONTRIBUTING.mdto clarify translation contribution process with reference to this comment.Please check if the PR fulfills these requirements
Cheatsheets are up-to-date (rungo generate ./...)Code has been formatted (see here)Tests have been added/updated (see here for the integration test guide)Text is internationalised (see here)If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)