Some fixes in IdentityMap plugin #29
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes check for primary key - currently association_reflection[:primary_key] is not filled by default but lazy filled in method, so that check failed (at least in rails development mode).
Second commit fixes issue that model which had not called
plugin :identity_map
does not respect identity map of associated object. I don't really know, is including methods streight to Sequel::Model a best solution? but it just works.