Skip to content

Conversation

funny-falcon
Copy link
Contributor

First commit fixes check for primary key - currently association_reflection[:primary_key] is not filled by default but lazy filled in method, so that check failed (at least in rails development mode).

Second commit fixes issue that model which had not called plugin :identity_map does not respect identity map of associated object. I don't really know, is including methods streight to Sequel::Model a best solution? but it just works.

@jeremyevans
Copy link
Owner

I think the primary key checking (8d3bd27) is correct, but I object to the plugin modifying Sequel::Model itself (36218f3). See my comment on that commit. I'll probably cherry-pick 8d3bd27.

@funny-falcon
Copy link
Contributor Author

I made a comment there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants