Use "provided" scope for slf4j-api dependency (instead of compile)
#226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While "provided" makes no difference to maven in presence of "optional", it would reassure plugin writers that they too can depend on "provided" slf4j-api and rely on it being present on Jenkins.
oleg-nenashev
changed the title
compile)
jglick
reviewed
Aug 14, 2019
| @@ -286,7 +286,7 @@ | |||
| <groupId>org.slf4j</groupId> | |||
| <artifactId>slf4j-api</artifactId> | |||
| <version>${slf4jVersion}</version> | |||
| <scope>compile</scope> | |||
| <scope>provided</scope> | |||
| <!-- mark the API as optional so it is not packaged in the HPI but available during compile --> | |||
| <optional>true</optional> | |||
There was a problem hiding this comment.
In this case we could delete optional I think?
There was a problem hiding this comment.
I actually see some uses of optional with provided. Please see spotbugs-annotations and jcip-annotations. While it's not very useful, I don't want to break the pre-existing pattern.
|
Note: conflicts with #229. |
No worries, I would not mind discarding this PR is there is a better approach to declaring dependencies. |
|
I meant “conflict” in the technical sense of Git merges. #229 does not make this change, so we could do both. |
|
Let's go ahead with this PR for now, BOM is still in review |
|
Thanks @proski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While "provided" makes no difference to maven in presence of "optional", it would reassure plugin writers that they too can depend on "provided" slf4j-api and rely on it being present on Jenkins.