-
Notifications
You must be signed in to change notification settings - Fork 18
Test with Java 21 and modernization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gounthar
wants to merge
16
commits into
jenkinsci:master
Choose a base branch
from
gounthar:refactor/jdk-21-prerequisites-and-powermock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test with Java 21 and modernization #17
gounthar
wants to merge
16
commits into
jenkinsci:master
from
gounthar:refactor/jdk-21-prerequisites-and-powermock
+109
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/j0daJWhoh?organizationId=SmVua2lucyBDSQ%3D%3D Co-authored-by: Moderne <[email protected]>
[WARNING] <connection>scm:git:ssh://[email protected]/jenkinsci/multibranch-scan-webhook-trigger.git</connection> is invalid because ssh:// URLs do not work well with PCT. Replace it with <connection>scm:git:https://github.com/jenkinsci/multibranch-scan-webhook-trigger.git</connection>. In the future this warning will be changed to an error and will break the build.
[WARNING] <developerConnection>scm:git:ssh://[email protected]/jenkinsci/multibranch-scan-webhook-trigger.git</developerConnection> is invalid because ssh:// URLs do not work well with PCT. Replace it with <developerConnection>scm:git:[email protected]:jenkinsci/multibranch-scan-webhook-trigger.git</developerConnection>. In the future this warning will be changed to an error and will break the build.
Update required: commons-lang3 v3.x Jenkins API Plugin (commons-lang3-api 3.12.0-36.vd97de6465d5b_) to be updated to 3.13.0-62.v7d18e55f51e2 or higher
Update required: GitHub API Plugin (github-api 1.116) to be updated to 1.314-431.v78d72a_3fe4c3 or higher
…24.2'" This reverts commit 9bc08db.
…ator to version '596.v8c21c963d92d'.
This PR build is failing because it makes the plugin no longer compatible with Java 8, and the default build still uses Java 8. |
It now works, thank you so much! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Supersedes #6.
Supersedes #7.
Supersedes #11.
Supersedes #13.
Testing done
Confirmed tests pass with Java 21 on Linux.
Submitter checklist
Link to relevant issues in GitHub or Jira