Skip to content

Conversation

gounthar
Copy link

@gounthar gounthar commented Nov 9, 2023

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Supersedes #6.
Supersedes #7.
Supersedes #11.
Supersedes #13.

Testing done

Confirmed tests pass with Java 21 on Linux.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

gounthar and others added 16 commits November 9, 2023 12:41
[WARNING] <connection>scm:git:ssh://[email protected]/jenkinsci/multibranch-scan-webhook-trigger.git</connection> is invalid because ssh:// URLs do not work well with PCT. Replace it with <connection>scm:git:https://github.com/jenkinsci/multibranch-scan-webhook-trigger.git</connection>. In the future this warning will be changed to an error and will break the build.
[WARNING] <developerConnection>scm:git:ssh://[email protected]/jenkinsci/multibranch-scan-webhook-trigger.git</developerConnection> is invalid because ssh:// URLs do not work well with PCT. Replace it with <developerConnection>scm:git:[email protected]:jenkinsci/multibranch-scan-webhook-trigger.git</developerConnection>. In the future this warning will be changed to an error and will break the build.
 Update required: commons-lang3 v3.x Jenkins API Plugin (commons-lang3-api 3.12.0-36.vd97de6465d5b_) to be updated to 3.13.0-62.v7d18e55f51e2 or higher
Update required: GitHub API Plugin (github-api 1.116) to be updated to 1.314-431.v78d72a_3fe4c3 or higher
@gounthar gounthar marked this pull request as ready for review November 9, 2023 13:21
@gounthar
Copy link
Author

gounthar commented Nov 9, 2023

This PR build is failing because it makes the plugin no longer compatible with Java 8, and the default build still uses Java 8.
Could anyone please replay this build with the content of the Jenkinsfile provided in this PR?
Thanks a zillion! 🤗

@gounthar
Copy link
Author

gounthar commented Nov 9, 2023

It now works, thank you so much! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant