Skip to content

[JENKINS-62883] Add @Symbol to SCMSource and SCMNavigation descriptors #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

[JENKINS-62883] Add @Symbol to SCMSource and SCMNavigation descriptors #95

merged 1 commit into from
Jul 9, 2020

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Jun 30, 2020 •
edited
Loading

JENKINS-62883 Adding @Symbol to SCMSource and SCMNavigator descriptors.

@baymac

@Dohbedoh
Copy link
Contributor Author

Dohbedoh commented Jul 8, 2020

@baymac any chance this can get reviewed ?

@baymac
Copy link
Member

baymac commented Jul 9, 2020

@Dohbedoh I think we can assign different symbols to source and navigator. My suggestions are gitlabSource and gitlabNavigator.

@jetersen
Copy link
Member

jetersen commented Jul 9, 2020 •
edited
Loading

Please keep the change as it is

https://github.com/jenkinsci/github-branch-source-plugin/blob/2af5bd0abeb11bfc0b42a344fbce51edcb9d949b/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java#L1301
https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L1919

@baymac baymac merged commit 3e79964 into jenkinsci:master Jul 9, 2020
@Dohbedoh Dohbedoh deleted the improvement/JENKINS-62883 branch July 30, 2020 04:43
@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dohbedoh @baymac @jetersen @oleg-nenashev