Skip to content

Conversation

strangelookingnerd
Copy link
Contributor

Remove direct dependency to apache-httpcomponents-client-4-api at it is only used for HttpStatus.SC_NOT_FOUND in a test.

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd marked this pull request as ready for review February 20, 2025 12:14
@strangelookingnerd
Copy link
Contributor Author

@jenkinsci/gitlab-branch-source-plugin-developers Kindly requesting a review.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense to me. The plugin does not directly depend on the apache-httpcomponents-client-4-api but it does depend on the gitlab-api plugin and the gitlab-api plugin depends on apache-httpcomponents-client-4-api.

@basil basil merged commit 26a46aa into jenkinsci:master Aug 4, 2025
18 checks passed
@strangelookingnerd strangelookingnerd deleted the remove_httpclient branch August 4, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants