Skip to content

Conversation

jetersen
Copy link
Member

No description provided.

@jetersen jetersen requested a review from baymac August 29, 2019 16:13
@jetersen jetersen force-pushed the fix/gitlabProjectDisplayName branch from 5d3b4c6 to 1ab3274 Compare August 30, 2019 00:41
@jetersen jetersen changed the title add gitlab project display name add gitlab project avatar & display name. add gitlab group description Aug 30, 2019
@jetersen
Copy link
Member Author

So for project the display name is only available on mouse over?
Is this a bug in the SCM api or branch API? cc @stephenc
image

@jetersen
Copy link
Member Author

I wonder if SCMSourceBuilder's project name is the one being used?

@stephenc
Copy link
Member

The branch name is what people recognise, so it is the name displayed. The Description is on hover and is set from the description metadata action

@jetersen
Copy link
Member Author

jetersen commented Aug 30, 2019

@stephenc this is the repository list, that is misbehaving 😅

@stephenc
Copy link
Member

Behaviour is the same... repository name is like branch name

@jetersen
Copy link
Member Author

I guess is the best we are gonna get with GitLab.
@baymac Unless you want to change strategy from using the project path to remove the group name but still store it on the SCM source.

Like here
https://ci.jenkins.io/job/Plugins/

Though you can have subgroups with conflicting project names but then I would argue for using the following:
Omit group/user name on a SCM source then use Project Name or Sub group name / Project name

This is the code in question

It calls super and the second attribute is what is used for repository list.

@baymac
Copy link
Member

baymac commented Aug 30, 2019

@Casz I have also been testing, I am not sure if it is SCMNavigatorRequest or SCMSourceBuilder which is setting the display name of each project with the pathWithNamespace. Although I am fine with the current state, main part which is description of group and single project both works.

@jetersen
Copy link
Member Author

I'll do a separate PR for the display name as we most likely will have to add migration path for anyone currently using the plugin :)

@jetersen jetersen merged commit 7aec8d7 into master Aug 30, 2019
@jetersen jetersen deleted the fix/gitlabProjectDisplayName branch August 30, 2019 10:00
@jetersen jetersen added the enhancement New feature or request label Aug 30, 2019
@jetersen
Copy link
Member Author

jetersen commented Aug 30, 2019

For anyone in the future.

Naming on SCM API happens on request.process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants