-
Notifications
You must be signed in to change notification settings - Fork 99
add gitlab project avatar & display name. add gitlab group description #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java
Outdated
Show resolved
Hide resolved
5d3b4c6
to
1ab3274
Compare
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/gitlabbranchsource/helpers/GitLabHelper.java
Show resolved
Hide resolved
So for project the display name is only available on mouse over? |
I wonder if SCMSourceBuilder's project name is the one being used? |
The branch name is what people recognise, so it is the name displayed. The Description is on hover and is set from the description metadata action |
@stephenc this is the repository list, that is misbehaving 😅 |
Behaviour is the same... repository name is like branch name |
I guess is the best we are gonna get with GitLab. Like here Though you can have subgroups with conflicting project names but then I would argue for using the following: This is the code in question Line 24 in 224bdba
It calls super and the second attribute is what is used for repository list. |
@Casz I have also been testing, I am not sure if it is |
I'll do a separate PR for the display name as we most likely will have to add migration path for anyone currently using the plugin :) |
For anyone in the future. Naming on SCM API happens on |
No description provided.