add web hook cause #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baymac
reviewed
Aug 29, 2019
| String id = String.valueOf(objectAttributes.getIid()); | ||
| String sourceNameSpace = objectAttributes.getSource().getNamespace(); | ||
| String targetNameSpace = objectAttributes.getTarget().getNamespace(); | ||
| String namespace = |
There was a problem hiding this comment.
I suggest either you keep namespace camel cased or don't.
There was a problem hiding this comment.
I am not modifying the user typed name space.
and I am only using it to compare if source and target is the same
jetersen
commented
Aug 29, 2019
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabWebHookCause.java
Outdated
Show resolved
Hide resolved
jetersen
commented
Aug 29, 2019
src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabWebHookCause.java
Outdated
Show resolved
Hide resolved
baymac
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by GitLab Merge Request #1: bob => masterStarted by GitLab push by Joseph Petersen🙌