update gitlab4j-api, use long instead of int for id values #188
Conversation
|
@jetersen the Any way we can have the build pass with a SNAPSHOT depoendency? All I can say is it worked for me, never something you like a dev to say! ;-) |
pom.xml
Outdated
| <exclude>com.damnhandy:handy-uri-templates</exclude> | ||
| <exclude>org.jenkins-ci.main:jenkins-test-harness</exclude> |
There was a problem hiding this comment.
Perhaps better to introduce new version of parent pom and bom in separate PR?
This should not be needed.
There was a problem hiding this comment.
well I though it is required, to use the same minimum version as dependent plugins, otherwise the gitlab-branch-cource plugin will be made available to users of older jenkins without the new gitlab-api plugin.
There was a problem hiding this comment.
jenkins version != parent pom :)
Also 2.263.4 was released 2021-02-10 with plenty security issues. I'd hope more users are using a newer Jenkins version.
There was a problem hiding this comment.
Yeah, gitlab-branch-source-plugin is currently using plugin parent POM 4.1, which is from April 2020. That is a very old build toolchain. I'd suggest using something closer to when the minimum Jenkins version (i.e. 2.289.3) was released. 4.25 should be fairly easy to upgrade to. 4.26 had some breaking changes, so you may want to take one small bite at a time. :-)
There was a problem hiding this comment.
I filed #189 to try and make Daniel's life a little easier.
There was a problem hiding this comment.
Merged, @dcendents you should be able to rebase and remove these lines 😄
jetersen
force-pushed
the
update_gitlab4j_api
branch
from
e3ae723 to
c82a8ae
Compare
|
Sometimes I don't understand require upper bound deps 😖 |
|
Oh and we can also remove the direct dependency on |
|
Thank you for all the help with this effort @dcendents. It is highly appreciated. A few remaining questions from my side:
|
I just updated them on our production jenkins server, so far so good but it's a bank holiday to really quiet, I'll be able to properly check it tomorrow.
We don't use this plugin so it is not easy for me to test it either
I might have a look at it but not for a few days at least. |
|
Jenkins 2.319.1 JavaScript GUI Lib: ACE Editor bundle plugin (ace-editor): 1.1 |
|
@readonlyuser1 Java 8 or Java 11? Checking up on Jackson they should be there: |
|
@readonlyuser1 If you want to motivate others to help you, please provide steps to reproduce the problem from scratch, expected results, and actual results. |
Updating all id fields from int to long, required once the following
gitlab-apiplugin PR gets merged:jenkinsci/gitlab-api-plugin#7
Note: I have added the jenkins snapshot repository and using the snapshot version (that I deployed myself), they will need to be removed/updated after the
gitlab-api-pluginPR is merged and release.