Skip to content

Conversation

robross0606
Copy link
Contributor

@robross0606 robross0606 commented Mar 11, 2022

Added options for "Contextual" and "Simple" as per README and other
documentation.

This addressed the open JENKINS-63102. Details can be found on that ticket. This adds two additional options for Project Naming Strategy:
2022-03-11_08h52_52

This has been tested via mvn hpi:run:
2022-03-11_08h53_42

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Added options for "Contextual" and "Simple" as per README and other
documentation.
@robross0606 robross0606 changed the title [JENKINS-59759] Added two new Project Naming Strategies for "Contextual Path" and "Simple Path" [JENKINS-59759] Added two new Project Naming Strategies for "Contextual Project Path" and "Simple Project Path" Mar 11, 2022
@@ -93,7 +95,7 @@
private String credentialsId;

/**
* The behavioural traits to apply.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling fixes.

Copy link
Contributor Author

@robross0606 robross0606 Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the unintended spelling "fixes". My Eclipse spelling plugin is set to US English and it flagged a whole bunch of corrections based on US English. I can revert these if you like.

@robross0606 robross0606 force-pushed the JENKINS-59759_additional_naming_strategies branch from 15c96f7 to cc2f9db Compare March 17, 2022 18:39
@jetersen
Copy link
Member

Please resolve the conflict :)

…uctor` and `@DataBoundSetter`.

Also updated help details for naming strategy to clarify use cases.
@robross0606 robross0606 force-pushed the JENKINS-59759_additional_naming_strategies branch from 8a84939 to a7a046e Compare April 18, 2022 14:36
@robross0606 robross0606 changed the title [JENKINS-59759] Added two new Project Naming Strategies for "Contextual Project Path" and "Simple Project Path" [JENKINS-63102] Added two new Project Naming Strategies for "Contextual Project Path" and "Simple Project Path" Apr 18, 2022
@robross0606 robross0606 requested a review from jetersen April 18, 2022 15:02
@jetersen jetersen added the enhancement New feature or request label Apr 18, 2022
@jetersen jetersen merged commit cc98dc4 into jenkinsci:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants