Skip to content

Conversation

darinpope
Copy link
Contributor

Adding trimming to the following attributes:

  • Server URL (serverUrl)
  • Display Name (name)
  • Root URL for hooks (hooksRootUrl)
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -6,7 +6,8 @@

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.CoreMatchers.*;
import static org.hamcrest.CoreMatchers.nullValue;
Copy link
Contributor

@eugenelesnov eugenelesnov Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems redundant, since does not contain useful code changes. Consider merging it with previous commit or delete it if we don't need it

@@ -0,0 +1,65 @@
package io.jenkins.plugins.gitlabserverconfig.servers;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, specify the commit text according to its contents

Copy link
Contributor

@eugenelesnov eugenelesnov Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this commit can be merged with previous ones

Signed-off-by: Darin Pope <[email protected]>

more cleanup

refactor
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxSuRen LinuxSuRen merged commit 408d555 into jenkinsci:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants