-
Notifications
You must be signed in to change notification settings - Fork 99
Trim white space #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim white space #131
Conversation
Signed-off-by: Darin Pope <[email protected]>
@@ -6,7 +6,8 @@ | |||
|
|||
import static org.hamcrest.MatcherAssert.assertThat; | |||
import static org.hamcrest.Matchers.is; | |||
import static org.hamcrest.CoreMatchers.*; | |||
import static org.hamcrest.CoreMatchers.nullValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit seems redundant, since does not contain useful code changes. Consider merging it with previous commit or delete it if we don't need it
@@ -0,0 +1,65 @@ | |||
package io.jenkins.plugins.gitlabserverconfig.servers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, specify the commit text according to its contents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this commit can be merged with previous ones
Signed-off-by: Darin Pope <[email protected]> more cleanup refactor
…ce-plugin into trim-spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding trimming to the following attributes: