Skip to content

Setting ref field for GitLab commit status #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

Setting ref field for GitLab commit status #128

merged 1 commit into from
Apr 20, 2021

Conversation

cpt1gl0
Copy link
Contributor

@cpt1gl0 cpt1gl0 commented Mar 12, 2021 •
edited
Loading

This will properly set the ref field when posting GitLab commit status.

@cpt1gl0 cpt1gl0 mentioned this pull request Mar 12, 2021
Closed
@cpt1gl0
Copy link
Contributor Author

cpt1gl0 commented Mar 12, 2021

Resolves issue #125

@cpt1gl0
Copy link
Contributor Author

cpt1gl0 commented Apr 13, 2021

@eugenelesnov:
Hi Eugene! Could you maybe take a quick look at this two-line pull request and merge it if you are okay with it?

@eugenelesnov
Copy link
Contributor

@cpt1gl0 Hey! Unfortunately, I do not have permission to write to this repository. Anyway, I approved this PR.
It would be nice to wait for some feedback from others now

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Apr 20, 2021
LinuxSuRen
LinuxSuRen approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @cpt1gl0 , thanks for your contribution.

LGTM

@LinuxSuRen LinuxSuRen merged commit f66e638 into jenkinsci:master Apr 20, 2021
@cpt1gl0
Copy link
Contributor Author

cpt1gl0 commented Apr 20, 2021

Hi @LinuxSuRen, thanks for merging!

@LinuxSuRen
Copy link
Member

Hi @LinuxSuRen, thanks for merging!

No worries.

This was referenced Apr 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

+1 more reviewer

@eugenelesnov eugenelesnov eugenelesnov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpt1gl0 @eugenelesnov @LinuxSuRen