Skip to content

Don't prepend publicPath to absolute URLs #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Don't prepend publicPath to absolute URLs #619

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efd4131
Don't prepend publicPath to absolute URLs
japgolly Mar 19, 2017
e8ed47a
Travis CI failed due to style rules
japgolly Mar 19, 2017
878103e
Support scheme-agnostic CDN links
japgolly Mar 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,12 @@ HtmlWebpackPlugin.prototype.htmlWebpackPluginAssets = function (compilation, chu

// Prepend the public path to all chunk files
var chunkFiles = [].concat(chunk.files).map(function (chunkFile) {
return publicPath + chunkFile;
if (/^(?:[a-z][a-z0-9+\-.]*:)?\/\//.test(chunkFile)) {
// If the chunkFile is a URL (eg. a CDN), use it as is
return chunkFile;
} else {
return publicPath + chunkFile;
}
});

// Append a hash for cache busting
Expand Down