forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Change build system to hereby #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dd39a6 to
d6f739a
Compare
3226085 to
d375574
Compare
9e940bc to
b3cfe4f
Compare
d375574 to
459e8a7
Compare
b3cfe4f to
b143f9b
Compare
459e8a7 to
a7df000
Compare
b143f9b to
d051afa
Compare
a7df000 to
ffd5699
Compare
d051afa to
9ff95ce
Compare
ffd5699 to
7cb5a91
Compare
9ff95ce to
52b1b07
Compare
7cb5a91 to
4ada7a6
Compare
52b1b07 to
2c247fb
Compare
4ada7a6 to
16238e3
Compare
2c247fb to
93f3463
Compare
16238e3 to
ca1ee4b
Compare
93f3463 to
34ac679
Compare
ca1ee4b to
948cdee
Compare
34ac679 to
fd53551
Compare
948cdee to
7fed31f
Compare
fd53551 to
b90bad3
Compare
07e6e98 to
57a42fd
Compare
d11a9bf to
ec996eb
Compare
57a42fd to
b937aa1
Compare
ec996eb to
8c7aa6d
Compare
b937aa1 to
f9dfd0d
Compare
8c7aa6d to
e9faf2b
Compare
f9dfd0d to
3904a77
Compare
e9faf2b to
b9364c2
Compare
3904a77 to
2a7ca51
Compare
b9364c2 to
4df9da7
Compare
2a7ca51 to
6f6eb7a
Compare
4df9da7 to
ac6e224
Compare
6f6eb7a to
d731c76
Compare
ac6e224 to
0170def
Compare
d731c76 to
2737d5e
Compare
0170def to
87ff7a9
Compare
2737d5e to
5d97edb
Compare
87ff7a9 to
d731995
Compare
5d97edb to
5622ce9
Compare
d731995 to
09c2a03
Compare
5622ce9 to
8db2dd8
Compare
09c2a03 to
4cd9643
Compare
8db2dd8 to
831f6f1
Compare
4cd9643 to
ec50b19
Compare
831f6f1 to
1dce951
Compare
ec50b19 to
ee3f3d5
Compare
This eliminates a significant number of dependencies, eliminating all npm audit issues, speeding up `npm ci` by 20%, and overall making the build faster (faster startup, direct code is faster than streams, etc) and clearer to understand. I'm finding it much easier to make build changes for the module transform with this; I can more clearly indicate task dependencies and prevent running tasks that don't need to be run. Given we're changing our build process entirely (new deps, new steps), it seems like this is a good time to change things up.
1dce951 to
ab8acee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates a significant number of dependencies, eliminating all
npm audit issues, speeding up
npm ciby 20%, and overall making thebuild faster (faster startup, direct code is faster than streams, etc)
and clearer to understand.
I'm finding it much easier to make build changes for the module
transform with this; I can more clearly indicate task dependencies and
prevent running tasks that don't need to be run.
Given we're changing our build process entirely (new deps, new steps),
it seems like this is a good time to change things up.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: