Add required helm repositories for Jaeger demo deployment #7403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahat sagar <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7403 +/- ##
==========================================
+ Coverage 96.45% 96.46% +0.01%
==========================================
Files 375 375
Lines 22878 22951 +73
==========================================
+ Hits 22067 22140 +73
Misses 613 613
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Jul 30, 2025
| @@ -11,6 +11,11 @@ if [ ! -d "helm-charts" ]; then | |||
| git clone https://github.com/jaegertracing/helm-charts.git | |||
| cd helm-charts | |||
| git checkout v2 | |||
| echo "Adding required Helm repositories..." | |||
| helm repo add bitnami https://charts.bitnami.com/bitnami | |||
There was a problem hiding this comment.
What are you using from bitnami? They recently announced that they will stop supporting free charts.
There was a problem hiding this comment.
Helm was prompting to add these repositories , so I added them here
yurishkuro
approved these changes
Jul 30, 2025
yurishkuro
added
the
changelog:exprimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test