Skip to content

make TerrainTestCollision more user-friendly #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2018
Merged

make TerrainTestCollision more user-friendly #827

merged 1 commit into from
Feb 26, 2018

Conversation

@stephengold
Copy link
Member

  • Change the initial camera position so that the terrain is visible.
  • Display a hint about the T key.
  • Fix a bug where the T key had to be pressed twice before it would work.

Nehon
Nehon approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@Nehon Nehon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@stephengold stephengold merged commit 0014ede into jMonkeyEngine:master Feb 26, 2018
@stephengold stephengold added this to the v3.2.2 milestone Dec 20, 2018
stephengold added a commit that referenced this pull request Dec 31, 2018
@stephengold
TerrainTestTile: T key had to be pressed 2x before effect (see PR #827)
8cd5894
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Dec 31, 2018
stephengold added a commit that referenced this pull request Mar 17, 2019
@stephengold
TerrainTestTile: T key had to be pressed 2x before effect (see PR #827)
f00f682
@stephengold
Copy link
Member Author

See also commits d636049 and ceea055 , which addressed the same issues in other terrain tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Nehon Nehon Nehon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

defect Something that is supposed to work, but doesn't. Less severe than a "bug"

Projects

None yet

Milestone

v3.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@stephengold @Nehon