jme3-examples: TestLodGeneration - test code optimization #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaRnMcDonuts
approved these changes
Jun 1, 2025
|
I'll merge this in the next 24-48 hours. I will also merge some of your other PRs that are marked "approved" in the same time frame. Most of the PRs I've already marked as approved are the javadoc/formatting ones with little to no chance of breaking anything, or some other ones that I could easily review the code to be sure it looks safe. So I may leave some PRs open longer if they are bigger or look like there's more changes to the code functionality that should require more thorough review. I'll soon put together a list of the higher risk and larger PRs and post that to the jme forums to ensure they get more review, especially some that may be beyond my areas of expertise. Thanks for your efforts with all the PRs lately! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
TestLodGenerationexample code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.