Skip to content

Add MipMaps to PBRTerrainAdvancedTest.java #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Add MipMaps to PBRTerrainAdvancedTest.java #2289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions jme3-examples/src/main/java/jme3test/terrain/PBRTerrainAdvancedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
import com.jme3.texture.Image;
import com.jme3.texture.Texture;
import com.jme3.texture.Texture.WrapMode;
import com.jme3.texture.Texture.MagFilter;
import com.jme3.texture.Texture.MinFilter;
import com.jme3.texture.TextureArray;
import java.util.ArrayList;
import java.util.List;
Expand Down Expand Up @@ -279,10 +281,10 @@ private void setUpTerrainMaterial() {
TextureArray metallicRoughnessAoEiTextureArray = new TextureArray(metallicRoughnessAoEiMapImages);

//apply wrapMode to the whole texture array, rather than each individual texture in the array
albedoTextureArray.setWrap(WrapMode.Repeat);
normalParallaxTextureArray.setWrap(WrapMode.Repeat);
metallicRoughnessAoEiTextureArray.setWrap(WrapMode.Repeat);

setWrapAndMipMaps(albedoTextureArray);
setWrapAndMipMaps(normalParallaxTextureArray);
setWrapAndMipMaps(metallicRoughnessAoEiTextureArray);
//assign texture array to materials
matTerrain.setParam("AlbedoTextureArray", VarType.TextureArray, albedoTextureArray);
matTerrain.setParam("NormalParallaxTextureArray", VarType.TextureArray, normalParallaxTextureArray);
Expand Down Expand Up @@ -430,6 +432,12 @@ private void setUpTerrain() {
rootNode.attachChild(terrain);
}

private void setWrapAndMipMaps(Texture texture){
texture.setWrap(WrapMode.Repeat);
texture.setMinFilter(MinFilter.Trilinear);
texture.setMagFilter(MagFilter.Bilinear);
}

private void setUpLights() {
LightProbe probe = (LightProbe) assetManager.loadAsset("Scenes/LightProbes/quarry_Probe.j3o");

Expand Down