Skip to content

Conversation

@JNightRider
Copy link
Contributor

@JNightRider JNightRider commented Mar 28, 2024

This PR is to remove a 'redundancy' in the size depth settings in LwjglCanvas

...
[Line 500] glData.depthSize = settings.getBitsPerPixel();
...
[Line 504] glData.depthSize = settings.getDepthBits();

It doesn't cause any problems but it is better to clean it.

Copy link
Member

@stephengold stephengold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scenemax3d scenemax3d added this to the v3.7.0 milestone Mar 30, 2024
@scenemax3d scenemax3d merged commit 3a556b5 into jMonkeyEngine:master Mar 30, 2024
@JNightRider JNightRider deleted the LwjglCanvas_logical_error] branch March 30, 2024 19:26
scenemax3d pushed a commit that referenced this pull request Mar 30, 2024
 remove a 'redundancy' in the size depth settings in LwjglCanvas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants