-
-
Couldn't load subscription status.
- Fork 1.2k
Deprecate TangentBinormalGenerator #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mpute tangent for unsupported mesh types. Add generate(Mesh) method to match TangentBinormalGenerator
…m TangentBinormalGenerator to TangentUtils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo on a javadoc link needs fixing.
|
|
||
| /** | ||
| * | ||
| * @deprecated This is an outdated and non-standard method. Please use @{link MikktspaceTangentGenerator} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change @{link to {@link.
|
Hi guys, what is the status of this PR ? Is it complete ? |
After reviewing the code in regards to its functionality (not for formatting or anything else), I would say it is complete and looks ready to be merged. I have also been using the MikktSpaceTangentGenerator extensively with a fairly wide variety of models in my own project and editor for at least 2 years now, so I am personally confident in its reliability. I'd also like to try to merge this to get it into the 3.8 alpha release that will be out soon. That way we can get jme users testing these changes as early in the alpha / beta process as possible. But (since this PR has been sitting for a while) I will wait a few days before merging, in case @riccardobl has anything to add or wants to change anything before the PR is merged. |
|
I merged this PR so it will be in the first 3.8.0-alpha1 release in the next day or so. There were many engine examples updated in this PR to use MikktspaceTangentGenerator and there will be a handful of test-cases that will need testing, so I think getting this into the alpha release asap is important. I took a screenshots showing a list of every test-case / example that was changed in this PR, so that will hopefully make it easier for users to reference this list to test all of these in rapid succession: |

The purpose of this PR is to deprecate TangentBinormalGenerator
This PR needs to be tested