Add simple math methods to Vector3f #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added these convenience multiplication and division methods that were missing from the Vector3f class, and did my best to also follow the same javadoc formatting. Let me know if this looks alright and then I will do the same for Vector2f and Vector4f. Should I make the changes to Vector2f and Vector4f in this PR or should I make a new PR for each?
Either way is fine. |
|
Looks good so far. |
yaRnMcDonuts
changed the title
|
Unless there's more to discuss, I plan to integrate this to "master" in about 24 hours. |
|
Thanks for your contribution, @yaRnMcDonuts. |
|
Glad to contribute whenever I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added these convenience multiplication and division methods that were missing from the Vector3f class, and did my best to also follow the same javadoc formatting that the rest of the similar methods have.
Let me know if this looks alright and then I will do the same for Vector2f and Vector4f. And should I make the changes to Vector2f and Vector4f in this PR or should I make a new PR for each?