Skip to content

NPE in reloadJoysticks() when joystick lacks buttons #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

NPE in reloadJoysticks() when joystick lacks buttons #1740

merged 1 commit into from
Jan 12, 2022

Conversation

@heliflieger
Copy link
Contributor

@heliflieger heliflieger commented Jan 11, 2022 •
edited
Loading

Close #1739

@heliflieger heliflieger changed the title Close #1739 NullPointerException with JoyStick and no buttons Jan 11, 2022
stephengold
stephengold approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@stephengold stephengold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stephengold stephengold added this to the v3.5.0 milestone Jan 11, 2022
@stephengold stephengold linked an issue Jan 11, 2022 that may be closed by this pull request
NullPointerException with JoyStick and no buttons #1739
Closed
@stephengold stephengold changed the title NullPointerException with JoyStick and no buttons NPE in reloadJoysticks() when joystick lacks buttons Jan 12, 2022
@stephengold stephengold changed the base branch from v3.4 to master January 12, 2022 20:25
@stephengold stephengold changed the base branch from master to v3.4 January 12, 2022 20:26
@stephengold stephengold merged commit 8385b43 into jMonkeyEngine:v3.4 Jan 12, 2022
@stephengold
Copy link
Member

I'll cherry-pick this to the "master" and "v3.5" branches.

stephengold pushed a commit that referenced this pull request Jan 12, 2022
@heliflieger @stephengold
solve issue 1739 (NPE in reloadJoysticks() when joystick lacks buttons)
72a21b1 
#1740
stephengold pushed a commit that referenced this pull request Jan 12, 2022
@heliflieger @stephengold
solve issue 1739 (NPE in reloadJoysticks() when joystick lacks buttons)
efe5ba6 
#1740
@stephengold
Copy link
Member

Thanks for your contribution, @heliflieger.

For your future PRs, please use "master" branch as the base.

@stephengold stephengold added the bug Something that is supposed to work, but doesn't. More severe than a "defect". label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephengold stephengold stephengold approved these changes

Assignees

No one assigned

Labels

bug Something that is supposed to work, but doesn't. More severe than a "defect".

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

NullPointerException with JoyStick and no buttons

2 participants

@heliflieger @stephengold