Skip to content

Conversation

@stephengold
Copy link
Member

Per discussion at the Hub/Forum: https://hub.jmonkeyengine.org/t/normalrecalccontrol-not-working-outside-of-sdk/44140/6

This makes the fixNormals() method public.

@stephengold stephengold added this to the Future Release milestone Jan 11, 2022
@yaRnMcDonuts
Copy link
Member

I believe we also want to publicize the fixNormalEdges() method, I overlooked that when I made my post late last night, but that method is also necessary for generating the normals on the edges of each terrain patch, while fixNormals handles generating the noramls within each individual TerrainPatch.

I also think I found an alternate solution that fixes NormalRecalcControl that I'll submit in another PR after testing a bit more, but I still think it is beneficial to publicize these methods so they can be called directly in situations where you don't need a control constantly checking for updates.

@stephengold
Copy link
Member Author

I'm putting this PR on hold until I see your PR.

@stephengold stephengold marked this pull request as draft January 11, 2022 19:17
@stephengold stephengold marked this pull request as ready for review January 17, 2022 06:09
@stephengold
Copy link
Member Author

This PR now publicizes both methods. Unless there's substantial discussion, I plan to integrate this in about 24 hours.

@stephengold stephengold merged commit 6e95d2b into master Jan 20, 2022
@stephengold stephengold deleted the sgold/fix-normals branch January 20, 2022 22:13
@Ali-RS Ali-RS modified the milestones: Future Release, v3.6.0 Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants