fix issues #1193 and #1558 for Linux/Windows (LWJGL v3 hangs) #1690

bob0bob · 2021-12-01T05:26:00Z

TestAWTPanels hangs with LWJGL v3 #1558 / jme3test.app.TestApplication hangs with LWJGL3 #1193

Made LWJGL3-JME to launch in the same way the LWJGL2-JME launches. This always Windows and Linux to run, still needs testing on Max OS X

… in AppSettings. ‘CenterWindow’, ‘WindowXPosition’ and ‘WindowYPosition’ variables. This way these variable will be saved in the profile when the profile is saved, and be reloaded. I added ‘CenterWindow’ to be added with a ‘true’ value for the default value so it will run just like it did before. But if you set ‘CenterWindow’ to ‘false’ then inside LwjglWindow.java (lwjgl3 code) it will look at these new values, it will determine to center the window or use the position values to place the window back at the location the user last moved it to. Of course, these values are only updated if the “program” updates this value. So if you want to save screen position, you can save them on closing to and on restart put the window back into the same location.

LWJGL3-JME library would block the current thread when executing LWJGL3. Instead of calling run() that is blocking, made it work like LWJGL2-JME library when they start it as a thread so run gets called. I commented out the run() function and replaced it with Thread.start().

…at once.

…o master

LWJGL3-JME projects was doing a call that is blocking the current thread. I changed it to match how LWJGL2-JME project launches the Context Window.

…TestApplication hangs with LWJGL3 jMonkeyEngine#1193 Made LWJGL3-JME to launch in the same way the LWJGL2-JME launches. This always Windows and Linux to run, still needs testing on Max OS X

bob0bob · 2021-12-01T05:36:46Z

This is also related to issue jme-lwjgl3 - bug for starting app #1514

Jeddic · 2021-12-01T22:02:45Z

From what I can tell you just reverted the changes? I can already tell you this breaks osx which is why it was changed in the first place.

…estApplication hangs with LWJGL3 jMonkeyEngine#1193 Made LWJGL3-JME to launch in the same way the LWJGL2-JME launches. This always Windows and Linux to run, still needs testing on Max OS X

bob0bob · 2021-12-02T03:48:09Z

I made more changes, based on the history of the changes and other issues about this issue. It does end up checking to see if it is a Mac and do something else. This is solution I'm using on my engine, it needs to be tested but I worry there is not anyone to test for it. I will cross my fingers for one to step up to test.

pspeed42 · 2021-12-02T03:55:17Z

We should try to come up with code that doesn't use "magic guess the OS" string checks. Even if that means changing the semantics of what start() means.

stephengold · 2021-12-02T07:27:19Z

Sorry if this is a stupid question, but why use mainThread.run() instead of mainThread.start()?

bob0bob · 2021-12-02T14:17:17Z

I found a way to check from inside LWJGL3, they have a call to return a ENUM for the 3 types of hardware that is support. I will put that in but last night my eclipse build started to mess up and I couldn't get it to run in debug to verify it.

The enum returns, WINDOWS, LINUX or MAC.

They even have a class to verify it is running on the main thread and return false is not, so you can throw an exception.

Jeddic · 2021-12-02T23:50:48Z

I just confirmed that this crashes on OSX.

…G3 class that determines this instead.

bob0bob · 2021-12-03T06:07:16Z

I made changes to remove the string comparison. This does fix the Windows and Linux. Jeddic, if you have a MAC, Please look into a solution for Mac. Looking into the JME-LWJGL2 library the create() method ends up doing the same for the Mac.

This is moving forward to getting LWJGL3 functioning. I'm not sure what "CRASH" means, because it does the run() call on the current thread. If anything this is not a solution for Mac, but for other 2 OS.

stephengold · 2021-12-03T08:08:35Z

@Jeddic next time, please copy/paste the stack trace

Jeddic · 2021-12-03T15:14:37Z

SEVERE: Uncaught exception thrown in Thread[jME3 Main,5,main]
java.lang.ExceptionInInitializerError
	at org.lwjgl.glfw.GLFW.glfwInit(GLFW.java:1046)
	at com.jme3.system.lwjgl.LwjglWindow.createContext(LwjglWindow.java:197)
	at com.jme3.system.lwjgl.LwjglWindow.initInThread(LwjglWindow.java:515)
	at com.jme3.system.lwjgl.LwjglWindow.run(LwjglWindow.java:650)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalStateException: GLFW may only be used on the main thread. This check may be disabled with Configuration.GLFW_CHECK_THREAD0.
	at org.lwjgl.glfw.EventLoop.<clinit>(EventLoop.java:30)
	... 5 more

There you go.

Jeddic · 2021-12-03T15:36:05Z

So I tested the current version and it is close, but calling mainthread.run() won't work. There isn't a runnable assigned so it immediately returns and closes the application. Just calling run() directly works for me.

…ut the Linux and Windows version will start to work.

bob0bob · 2021-12-03T18:34:52Z

Jeddic, thanks. I but the run() call back for MacOS. This will not solve the issue for Mac and AWT but will for Linux and Windows.

Jeddic · 2021-12-03T18:55:39Z

Yah, fixing it for osx will probably take changing the canvas to use the lwjgl-awt project. Let me know if there is anything else that needs to be tested.

stephengold · 2021-12-05T19:11:58Z

If this PR doesn't solve the issue for macOS, then why not remove the if (Platform.get() == Platform.MACOSX) { clause?

Also, our preferred Java style specifies that braces are used with if statements, even when the body is empty or contains only a single statement, so the if (waitfor) clause(s) need braces.

Jeddic · 2021-12-06T01:39:59Z

Well, this pull request should fix the issue for windows / linux. The clause is there specifically so it doesn't break macOS in the process.

bob0bob · 2021-12-06T02:08:35Z

I added the braces for the correct coding.

We have to leave in the check for MAC, because the Mac needs the run() call. That call is blocking and non-returning. But with the thread().start(), that is a non-blocking call that will allow the return so the rest of the code gets executed after the call to app.start() in main.

stephengold · 2021-12-06T23:12:13Z

Rather than slog through another round of review, I fixed a couple minor issues and integrated the PR.

Thank you for your contribution to the Engine!

stephengold · 2021-12-07T00:02:01Z

Now TestAWTPanels is broken in a new and different way. See issue #1558 for details.

jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java

bob0bob · 2022-01-04T09:18:01Z

Okay, I checked in the changes and tested it against the example from the forum where it is hanging.

bob0bob · 2022-01-04T09:19:09Z

Do I start a new merge request to get the changes over since it has already been merged.

Ali-RS · 2022-01-04T09:24:35Z

No need for that, it is already fixed in JME v3.5.0-beta5. See #1722.
Sorry for the inconvenience.

bob0bob and others added 18 commits November 21, 2021 23:33

Merge branch 'master' of https://github.com/bob0bob/jmonkeyengine

7bcba98

formatting and comments changes.

ce24716

Merge branch 'jMonkeyEngine:master' into master

1b0507e

removing unwanted changes, since you can't do multiple pull requests …

f0489b8

…at once.

Merge branch 'master' of https://github.com/bob0bob/jmonkeyengine int…

e5f608d

…o master

formatting issues.

a5b0e37

changed parameter naming to be more consistency with other items.

26937ca

jme3test.app.TestApplication hangs with LWJGL3 jMonkeyEngine#1193

3832d37

LWJGL3-JME projects was doing a call that is blocking the current thread. I changed it to match how LWJGL2-JME project launches the Context Window.

jme3test.app.TestApplication hangs with LWJGL3 jMonkeyEngine#1193 (#3)

811493c

LWJGL3-JME projects was doing a call that is blocking the current thread. I changed it to match how LWJGL2-JME project launches the Context Window.

removing unwanted changes.

db0d9ff

AppSettings: enhance the new javadoc

5eb2690

AppSettings: capitalize Window{X/Y}Position consistent w/other settings

72d008d

LwjglWindow: convert tabs to spaces

f7c5ec7

AppSettings: re-arrange @see tags in javadoc

4544d64

Merge branch 'jMonkeyEngine:master' into master

0d28d62

TestAWTPanels hangs with LWJGL v3 jMonkeyEngine#1558 / jme3test.app.…

03f795a

…TestApplication hangs with LWJGL3 jMonkeyEngine#1193 Made LWJGL3-JME to launch in the same way the LWJGL2-JME launches. This always Windows and Linux to run, still needs testing on Max OS X

TestAWTPanels hangs with LWJGL v3 jMonkeyEngine#1558 / jme3test.app.T…

2f85213

…estApplication hangs with LWJGL3 jMonkeyEngine#1193 Made LWJGL3-JME to launch in the same way the LWJGL2-JME launches. This always Windows and Linux to run, still needs testing on Max OS X

stephengold added this to the v3.5.0 milestone Dec 2, 2021

Removed the string compare to determine if it is a Mac OS. Using LWJL…

83ed844

…G3 class that determines this instead.

Making changes for Mac os. The AWT examples will not work under Mac b…

d49e36e

…ut the Linux and Windows version will start to work.

added braces that are need for formatting.

c39eb23

stephengold linked an issue Dec 6, 2021 that may be closed by this pull request

jme3test.app.TestApplication hangs with LWJGL3 #1193

Closed

LwjglWindow: copyright year, log message, correct indents and braces

fb74379

stephengold changed the title ~~Lwjgl3 hangs #1558 / 1193~~ fix issues #1158 and #1193 for Linux/Windows (LWJGL v3 hangs) Dec 6, 2021

stephengold changed the title ~~fix issues #1158 and #1193 for Linux/Windows (LWJGL v3 hangs)~~ fix issues #1193 and #1558 for Linux/Windows (LWJGL v3 hangs) Dec 6, 2021

stephengold linked an issue Dec 6, 2021 that may be closed by this pull request

TestAWTPanels crashes with LWJGL v3 on Linux #1558

Closed

stephengold merged commit 38752ea into jMonkeyEngine:master Dec 6, 2021

stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Dec 6, 2021

stephengold mentioned this pull request Dec 6, 2021

TestAWTPanels crashes with LWJGL v3 on Linux #1558

Closed

stephengold removed a link to an issue Dec 7, 2021

TestAWTPanels crashes with LWJGL v3 on Linux #1558

Closed

bob0bob deleted the LWJGL3_Hangs_#1558 branch December 9, 2021 03:01

Ali-RS reviewed Dec 26, 2021

View reviewed changes

jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java Show resolved Hide resolved

Ali-RS mentioned this pull request Feb 9, 2023

jme-lwjgl3 - bug for starting app #1514

Closed

Uh oh!

fix issues #1193 and #1558 for Linux/Windows (LWJGL v3 hangs) #1690

fix issues #1193 and #1558 for Linux/Windows (LWJGL v3 hangs) #1690

Uh oh!

Conversation

bob0bob commented Dec 1, 2021

Uh oh!

bob0bob commented Dec 1, 2021

Uh oh!

Jeddic commented Dec 1, 2021

Uh oh!

bob0bob commented Dec 2, 2021

Uh oh!

pspeed42 commented Dec 2, 2021

Uh oh!

stephengold commented Dec 2, 2021

Uh oh!

bob0bob commented Dec 2, 2021

Uh oh!

Jeddic commented Dec 2, 2021

Uh oh!

bob0bob commented Dec 3, 2021

Uh oh!

stephengold commented Dec 3, 2021

Uh oh!

Jeddic commented Dec 3, 2021

Uh oh!

Jeddic commented Dec 3, 2021

Uh oh!

bob0bob commented Dec 3, 2021

Uh oh!

Jeddic commented Dec 3, 2021

Uh oh!

stephengold commented Dec 5, 2021

Uh oh!

Jeddic commented Dec 6, 2021

Uh oh!

bob0bob commented Dec 6, 2021

Uh oh!

stephengold commented Dec 6, 2021

Uh oh!

stephengold commented Dec 7, 2021

Uh oh!

Uh oh!

bob0bob commented Jan 4, 2022

Uh oh!

bob0bob commented Jan 4, 2022

Uh oh!

Ali-RS commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ali-RS commented Jan 4, 2022 •

edited

Loading