Skip to content

fix issue 1672 (inefficient logging in Node.java) #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2021
Merged

fix issue 1672 (inefficient logging in Node.java) #1673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e787083
#1672 Logging statements should be guarded
Nov 23, 2021
d31152d
#1672 Fix performance penalty of logger without guard
Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jme3-core/src/main/java/com/jme3/scene/Node.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ public Spatial detachChildAt(int index) {
Spatial child = children.remove(index);
if (child != null) {
child.setParent(null);
logger.log(Level.FINE, "{0}: Child removed.", this.toString());
logger.log(Level.FINE, "{0}: Child removed.", this);

// since a child with a bound was detached;
// our own bound will probably change.
Expand Down Expand Up @@ -461,7 +461,7 @@ public void detachAllChildren() {
for (int i = children.size() - 1; i >= 0; i--) {
detachChildAt(i);
}
logger.log(Level.FINE, "{0}: All children removed.", this.toString());
logger.log(Level.FINE, "{0}: All children removed.", this);
}

/**
Expand Down