Skip to content

solve issue 1640 (CartoonEdgeFilter failing to override read() and write()) #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2021
Merged

solve issue 1640 (CartoonEdgeFilter failing to override read() and write()) #1647

merged 3 commits into from
Nov 10, 2021

Conversation

@capdevon
Copy link
Contributor

@capdevon capdevon commented Nov 9, 2021

this PR solve issue #1640

  • remove unused import and extra empty lines from CartoonEdgeFilter
  • add test case for CartoonEdgeFilter save and load

@capdevon
solve issue 1640 (CartoonEdgeFilter failing to override read() and
f5a4487 
write())

- remove unused import and extra empty lines from CartoonEdgeFilter
- add test case for CartoonEdgeFilter save and load
@stephengold stephengold linked an issue Nov 9, 2021 that may be closed by this pull request
CartoonEdgeFilter failing to override read() and write() #1640
Closed
@stephengold stephengold added this to the v3.5.0 milestone Nov 9, 2021
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Nov 9, 2021
@stephengold
Copy link
Member

The new test appears to be broken. Here's the call stack from the build:

> Task :jme3-effects:test FAILED

com.jme3.post.filters.CartoonEdgeFilterTest > testSaveAndLoad FAILED
    java.lang.NullPointerException
        at com.jme3.system.JmeSystem.getPlatformAssetConfigURL(JmeSystem.java:184)
        at com.jme3.asset.DesktopAssetManager.<init>(DesktopAssetManager.java:84)
        at com.jme3.post.filters.CartoonEdgeFilterTest.testSaveAndLoad(CartoonEdgeFilterTest.java:19)

@stephengold stephengold merged commit f67a843 into jMonkeyEngine:master Nov 10, 2021
@stephengold
Copy link
Member

Thank you for your contribution, @capdevon !

@capdevon capdevon deleted the capdevon-issue1640 branch November 10, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephengold stephengold stephengold left review comments

Assignees

No one assigned

Labels

defect Something that is supposed to work, but doesn't. Less severe than a "bug"

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

CartoonEdgeFilter failing to override read() and write()

2 participants

@capdevon @stephengold