ignore return values from AnimMigrationUtils.migrate() #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless there's substantive feedback, I plan to integrate this in 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our best guidance for how to use
AnimMigrationUtilsis found in 5 example apps in jme3-examples. However, 2 of those apps (TestJaimeandTestAttachmentsNode) assign return values frommigrate()to local variables, giving the impression that the model might be converted by creating a newSpatial.In fact,
migrate()converts models in place. Its return value is simply the argument. The assignments are redundant and also misleading, so this PR removes them fromTestJaimeandTestAttachmentsNode.