Skip to content

Conversation

@stephengold
Copy link
Member

This is mostly for typos in Java comments.

@stephengold stephengold added the Documentation Issues that affect the Wiki, Javadoc or any other form of documentation label Jul 6, 2021
@capdevon
Copy link
Contributor

capdevon commented Jul 7, 2021

Hi Stephen, great job as always!
There would also be the names of these two methods, in the MotionPath class, which start with a capital letter and do not follow the rules of the coding conventions of the java language.

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/cinematic/MotionPath.java#L148

private Geometry CreateLinearPath() { ... }

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/cinematic/MotionPath.java#L158

private Geometry CreateCatmullRomPath() { ... }

There should be no problem correcting them to lowercase, as the two methods are private.

@stephengold
Copy link
Member Author

You're right that those 2 methods should be renamed. However, it should be a separate PR.

@capdevon
Copy link
Contributor

capdevon commented Jul 9, 2021

Ok, I've opened a new issue. #1587

@stephengold stephengold added this to the Future Release milestone Jul 9, 2021
@stephengold stephengold merged commit 52568d7 into master Jul 15, 2021
@stephengold stephengold deleted the sgold-shader-typos branch July 15, 2021 01:21
@stephengold stephengold modified the milestones: Future Release, v3.5.0 Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Issues that affect the Wiki, Javadoc or any other form of documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants