Skip to content

Conversation

@wei-shiuan-chang
Copy link
Contributor

This pull request is to solve the issue #1349.
According to the definition of each axis and the process to get x, y, and z of Spherical coordinates from the method cartesianZToSpherical, the method sphericalToCartesianZ should be modified.

@stephengold
Copy link
Member

Thanks for your contribution to JMonkeyEngine!

@stephengold stephengold added this to the Future Release milestone Jun 14, 2021
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Jun 14, 2021
Copy link
Member

@stephengold stephengold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephengold stephengold merged commit ddf1460 into jMonkeyEngine:master Jun 14, 2021
@stephengold stephengold modified the milestones: Future Release, v3.5.0 Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

defect Something that is supposed to work, but doesn't. Less severe than a "bug"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FastMath.sphericalToCartesianZ() does not reverse cartesianZToSpherical()

2 participants