Skip to content

Conversation

@MeFisto94
Copy link
Member

For the physics tests, I've verified that reverting the related commits indeed flags the tests as failed.

@MeFisto94
Copy link
Member Author

I'm currently uncertain about the tests failing, for me jpeg was there when I used usePlatformConfig = true, maybe this is a result of the headless environment not supporting AWT/jpeg?

@MeFisto94
Copy link
Member Author

My force push should have addressed the issues, but the CI had connection reset intermittent connection errors.

@stephengold
Copy link
Member

You should be able to re-run the tests. Or would you like me to do it?

@MeFisto94
Copy link
Member Author

MeFisto94 commented Jun 11, 2021

I already did, but now they failed at another step. The Asset Manager setup is kinda picky, sometimes it does not pickup the Desktop.cfg, this time it seems the way I did it made it ignore the default locators.
I could swear that all tests ran fine on my headless environment, but I can now see the failing test on my regular system and work towards progress

Edit: looks like a typo when transfering the changes

@MeFisto94
Copy link
Member Author

FWIW the change was to add JmeSystem.newAssetManager(TestLocators.class.getResource("/com/jme3/asset/Desktop.cfg")); so that the Desktop.cfg is added instead of just using new DesktopAssetManager(true), because true will use the platform config, which is probably detected as the Headless System

@stephengold
Copy link
Member

Is this PR still in progress, or is it ready for review?

@MeFisto94
Copy link
Member Author

It's ready for review, the last push only fixed some codacy warnings related to tests not being in camelCase

@stephengold stephengold added this to the Future Release milestone Jul 9, 2021
@stephengold stephengold modified the milestones: Future Release, v3.5.0 Nov 2, 2021
@stephengold stephengold merged commit b32e1ae into jMonkeyEngine:master Nov 2, 2021
@stephengold stephengold added the examples specific to the jme3-examples sub-project label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples specific to the jme3-examples sub-project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants