-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Convert a few manual tests to unit tests #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm currently uncertain about the tests failing, for me jpeg was there when I used |
|
My force push should have addressed the issues, but the CI had connection reset intermittent connection errors. |
|
You should be able to re-run the tests. Or would you like me to do it? |
|
I already did, but now they failed at another step. The Asset Manager setup is kinda picky, sometimes it does not pickup the Desktop.cfg, this time it seems the way I did it made it ignore the default locators. Edit: looks like a typo when transfering the changes |
|
FWIW the change was to add |
|
Is this PR still in progress, or is it ready for review? |
|
It's ready for review, the last push only fixed some codacy warnings related to tests not being in camelCase |
d0daeaa to
11a5532
Compare
For the physics tests, I've verified that reverting the related commits indeed flags the tests as failed.