address issue #1528 (distinguish ARM macOS/Windows from other platforms) #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LWJGL v3.3 also adds support for Windows ARM64. It would be great to get that in here too, unfortunately I am not sure on the platform strings for that as I do not own a ARM64 windows machine. |
|
I agree, but unless we obtain property strings soon, let's make that a separate PR. |
stephengold
changed the title
|
Made WIP while I incorporate new information posted at issue #1528. |
|
Ready for review again. |
|
I don't have a way to test, but the changes look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to distinguish ARM Macs from X86/PPC Macs so that, as soon as LWJGL v3.3 released, JME can also support such platforms.