add range-check assertions to the IndexBuffer.put() methods #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1382 provides an example of how sloppy
IndexBufferallocations can cause bugs. To help uncover such bugs, this PR adds assertions to theput()methods ofIndexByteBufferandIndexShortBufferin order to detect attempts to write out-of-range indices. (See the discussion at issue #1382 .)I also modified the
createIndexBuffer()method to record the expected number of vertices. This enables the assertions to test against the expected number of vertices (instead of 128 or 65536) for stronger checking.