GltfLoader decodes file path uri #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeFisto94
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Looks good to me, given the mentioned caveats on the hub (problems with faulty exporters not escaping + or not escaping stuff at all).
Since this is caused by a faulty exporter, we shall fail there.
Requesting a review from paul as the final say as he's been into that discussion.
|
Seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the GltfLoader to properly decode the percent-format uri references in the gltf model file.
See https://hub.jmonkeyengine.org/t/jme-not-decoding-gltf-uri/43619/12 for discussion.
Thanks,
Trevor