Camera#contains javadoc updated #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The check plane is a small optimization. It's used to make sure that whatever plane caused the BV to be outside last time is checked first the next time. All of the planes will still be checked if the object passes that check. So your added code is not necessary. The only case where it would be of any benefit at all (and even then only a little) is if an application is constantly checking the BV of all of the spatials against a different camera every frame. And an app like that probably already has a hundred worse performance problems than missing this small optimization. |
kkolyan
force-pushed
the
camera_contains_javadoc_updated
branch
from
b1736a0 to
51233cb
Compare
kkolyan
force-pushed
the
camera_contains_javadoc_updated
branch
from
51233cb to
980f99f
Compare
|
Thanks for explanation. I removed lines with |
|
Is this ready to be integrated? |
|
Seems like it. |
stephengold
added
the
Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've caught unpredictable behavior, when tried to use
Camera.contains, then checked javadoc and found the reason why.But javadoc is a bit outdated. This PR updates javadoc according observable behavior.
Old javadoc:
New javadoc:
Discussion: https://hub.jmonkeyengine.org/t/camera-contains-javadoc-outdated/43320