Skip to content

Conversation

@rvandoosselaer
Copy link
Contributor

@rvandoosselaer rvandoosselaer commented Apr 10, 2020

fixes #1340

Check if the NB_PROBES identifier is set, if not set a default value of 0.

If needed I can remove the test class as I don't think it's really 'helpful' in this case, as it only loads and displays a model.

@stephengold
Copy link
Member

The fix itself looks good.

Thank you for providing a test case. Please add an explanation of how to tell whether the test passed or failed.

@rvandoosselaer
Copy link
Contributor Author

rvandoosselaer commented Apr 11, 2020

Hi, the only real check at the moment is looking at the log and see if a RenderException was thrown.

I don’t really see another way of checking this, unless you have an idea? If not, do you agree by keeping the fix and removing the test case?

@pspeed42
Copy link
Contributor

Yeah, I think the test is "Does this PBR model crash on a Mac?" or not.

@pspeed42
Copy link
Contributor

But maybe a comment in the test saying this would be good so someone doesn't have to look it up in github just to see. I think that might be what sgold is getting at.

@rvandoosselaer
Copy link
Contributor Author

Ok that sounds like a good idea. I’ll adapt it and add some more context.

@stephengold
Copy link
Member

I believe this PR is ready to be integrated.

@stephengold stephengold merged commit 26f393d into jMonkeyEngine:master Apr 13, 2020
@stephengold
Copy link
Member

Integrated into the v3.3 branch at 9a84e72 .

@stephengold stephengold added this to the v3.3.1 milestone Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shader compile error when checking for hardware skinning support on model with PBR material def.

3 participants