Deprecated light node - #1033

[grizeldi]

This fixes #1033.

Should I also deprecate the TestLightNode.java?

[stephengold]

In the past, I've deleted tests/examples that targeted deprecated features.

[stephengold]

There are 3 jme3-examples apps that use LightNode:

1. TestLightNode should be deleted.
2. TestConeVsFrustum should be modified to position the lights directly.
3. TestManyLightsSingle should be modified to position the lights directly.

[stephengold]

Stuck?

[grizeldi]

Not really, just don't have much time for coding these days. I'll try to do it asap.

[stephengold]

Just curious. No rush.

[grizeldi]

Been doing some work and figured out that TestConeVSFrustum will need some general cleanup. There are random variables that are never used and the class uses TempVars. Aren't those supposed to be used by the engine only?

[stephengold]

Yes, TempVars is intended only for internal use. Yes, examples should ... set a good example. However, cleanup of examples should probably go into a separate pull request unless it's clearly related to issue #1033.

[ghost]

What is the status of this?

[grizeldi]

I think I have some more stuff done locally but never pushed it, will have to check.

[grizeldi]

Okay, looked into it a bit and I'm not sure what TestConeVSFrustum is even supposed to do. There's some unused stuff and the test as a whole looks unfinished. Still have to check TestManyLightSingle.

[stephengold]

I believe that TestConeVSFrustrum is supposed to test the SpotLight.intersectsFrustum() method. When the test is running, drag with the right mouse button pressed to reposition the spotlight's cone. When the cone no longer intersects the frustum, its color changes to grey.

[MeFisto94]

Friendly reminder to have a look at this again :)

[MeFisto94]

Yearly reminder again :D