IllegalStateException when running TestAWTPanels with 3.6.0-beta1and and LWJGL 3

[Ali-RS]

Testing with JME 3.6.0-beta1 and LWJGL 3 on Linux I am getting this exception in:

> Task :TestAwtPanels.main()
Feb 09, 2023 1:45:24 PM com.jme3.system.JmeDesktopSystem initialize
INFO: Running on jMonkeyEngine 3.6.0-beta1
 * Branch: HEAD
 * Git Hash: ee91fb8
 * Build Date: 2023-01-24
Feb 09, 2023 1:45:25 PM com.jme3.app.LegacyApplication handleError
SEVERE: Failed to create display
java.lang.IllegalStateException
	at com.jme3.system.awt.AwtPanelsContext$AwtPanelsListener.reshape(AwtPanelsContext.java:67)
	at com.jme3.system.lwjgl.LwjglWindow.updateSizes(LwjglWindow.java:393)
	at com.jme3.system.lwjgl.LwjglWindow.createContext(LwjglWindow.java:370)
	at com.jme3.system.lwjgl.LwjglWindow.initInThread(LwjglWindow.java:582)
	at com.jme3.system.lwjgl.LwjglWindow.run(LwjglWindow.java:704)
	at java.lang.Thread.run(Thread.java:750)

jmonkeyengine/jme3-desktop/src/main/java/com/jme3/system/awt/AwtPanelsContext.java

Lines 65 to 68 in 925ff45

	@Override
	public void reshape(int width, int height) {
	throw new IllegalStateException();
	}

I think this has something to do with changes made in PR #1794

This results in some redundant callbacks (multiple callbacks for a single createContext())

[Ali-RS]

Should I modify this method to just log an error instead of throwing an exception?

jmonkeyengine/jme3-desktop/src/main/java/com/jme3/system/awt/AwtPanelsContext.java

Lines 65 to 68 in 925ff45

	@Override
	public void reshape(int width, int height) {
	throw new IllegalStateException();
	}

[stephengold]

Should I modify this method to just log an error instead of throwing an exception?

I think that would be a step in the right direction.

[Ali-RS]

I noticed oldFramebufferWidth and oldFramebufferHeight are never initialized to their default values provided in AppSettings (settings.getWidth(), settings.getHeight()) in LwjglWindow.createContext().

jmonkeyengine/jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java

Lines 156 to 157 in 3d203a1

	private int oldFramebufferWidth;
	private int oldFramebufferHeight;

Was this by intent? should we initialize them to the default value in AppSettings?
by adding

oldFramebufferWidth = settings.getWidth();
oldFramebufferHeight = settings.getHeight();

in LwjglWindow.createContext() before calling to updateSizes();

jmonkeyengine/jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java

Line 370 in 3d203a1

updateSizes();

this should prevent a redundant call to the reshape method.

@stephengold any thoughts?

[tonihele]

Yeah, I also fixed these here https://github.com/jMonkeyEngine/jmonkeyengine/pull/1868/files#diff-08ccfbcf3d7d07136246c83ffab37eb165bf63cc68a3a52370873710c3d6daee

to get things working..

[Ali-RS]

Also found a small mistake here

https://github.com/jMonkeyEngine/jmonkeyengine/pull/1794/files#r1103590630