Skip to content

chore: do not call shutdown twice #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: do not call shutdown twice #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b37ebcc
chore: do not call shutdown twice
Dec 3, 2019
d15d7e1
fix: do not require module to be a constructor fn
Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/factory-in-proc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ class FactoryInProc {
delete daemonOptions.config.Addresses
}

if (typeof daemonOptions.exec !== 'function') {
throw new Error('\'type\' proc requires \'exec\' to be a coderef')
}

const node = new InProc(daemonOptions)

if (daemonOptions.init) {
Expand Down
3 changes: 1 addition & 2 deletions src/ipfsd-daemon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,7 @@ class Daemon {
if (!this.subprocess) {
return this
}
await this.api.stop()
// TODO this should call this.api.stop

await this.killProcess(timeout)

if (this.disposable) {
Expand Down