AndroidProject.setPackageName: update build.gradle applicationId #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlynch
suggested changes
Dec 9, 2021
| @@ -50,7 +50,10 @@ export class AndroidProject { | |||
| } | |||
|
|
|||
| async setPackageName(packageName: string) { | |||
| this.manifest.getDocumentElement()?.setAttribute('package', packageName); | |||
| await Promise.all([ | |||
| this.manifest.getDocumentElement()?.setAttribute('package', packageName), | |||
There was a problem hiding this comment.
No need for the Promise.all here as the setAttribute is synchronous
There was a problem hiding this comment.
Right! Changing it right away. Thanks!
|
💪 awesome! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update build.gradle applicationId when calling project.setPackageName. #24