refactor: update major #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ota-meshi I think this PR is pretty much ready. But I do not understand why the documentation build fails on Netlify. Maybe you can help me: https://app.netlify.com/sites/heuristic-haibt-5d042e/deploys/6477c19ee446090008dc8d65#L155 🙏 |
Member
|
Thank you for great work! |
1 task
Member
|
Hmm. My local build seems to succeed. The version of Node is probably not the cause of the failure either. Maybe it's because of cache. |
Member
|
Hmm, I've re-run netlify build, but I met the build error I seem that that error is occured by vuepress deps |
Contributor
Author
|
.. I think I fixed the build? 😅 Reviews welcome! ❤️ |
ota-meshi
requested changes
Jun 9, 2023
docs/rules.md
Outdated
| @@ -0,0 +1,40 @@ | |||
| # Available Rules | |||
Member
There was a problem hiding this comment.
I think the url for this file has changed.
I think we should probably change it to docs/rules/index.md.
ota-meshi
reviewed
Jun 9, 2023
ota-meshi
reviewed
Jun 9, 2023
docs/rules/index.md
Outdated
| <!--prettier-ignore--> | ||
| | Rule ID | Description | | | ||
| |:--------|:------------|:---| | ||
| | [@intlify/vue-i18n/<wbr>no-deprecated-i18n-component](./rules/no-deprecated-i18n-component.html) | disallow using deprecated `<i18n>` components (in Vue I18n 9.0.0+) | :black_nib: | |
Member
There was a problem hiding this comment.
I think we probably need to change the path as well.
Suggested change
| | [@intlify/vue-i18n/<wbr>no-deprecated-i18n-component](./rules/no-deprecated-i18n-component.html) | disallow using deprecated `<i18n>` components (in Vue I18n 9.0.0+) | :black_nib: | | |
| | [@intlify/vue-i18n/<wbr>no-deprecated-i18n-component](./no-deprecated-i18n-component.html) | disallow using deprecated `<i18n>` components (in Vue I18n 9.0.0+) | :black_nib: | |
Co-authored-by: Yosuke Ota <[email protected]>
ota-meshi
added a commit
that referenced
this pull request
Oct 2, 2023
* chore(deps): Make import-fresh a proper dependency This is not a devDependency, because it's used in regular code in lib/utils/collect-keys.ts. This seems like an oversight in #377. * Create ten-insects-deny.md --------- Co-authored-by: Yosuke Ota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glob