change query to im.js #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Joyce-O Works as intended, good job! 👍 |
AdrianBZG
pushed a commit
that referenced
this pull request
Sep 3, 2020
When a user types in a dropdown, the filtering logic caused the UI to lock up. This degraded UX massively. The issue lied with the use of fuzzy searching. But fuzzy searching isn't really valuable for our case. Instead, a contextual search is more appropriate. This commit uses `flexSearch` to conduct contextual searches. Closes: #76 Closes: #77 Squashed commits: * Render a customized menu list for the select dropdown * Render a virtualized dropdown list * Keep the main popup open after selecting an item * Scroll the item into view is the use scrolls past it with the keyboard * Render the entire list of available item values * Perf: improve searching in constraint inputs with flexSearch * Increase the amount of filter results is returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Chai expectin order to assert the expected behaviourRelated issues and discussion
#71
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!