operator: GPU-plugin initImage #491
Conversation
|
@uniemimu this is what I had in mind. however, |
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 56.43% 56.41% -0.03%
==========================================
Files 30 30
Lines 2036 2035 -1
==========================================
- Hits 1149 1148 -1
Misses 816 816
Partials 71 71
Continue to review full report at Codecov.
|
|
LGTM now, I'll give it a try this week |
pkg/controllers/gpu/controller.go
Outdated
There was a problem hiding this comment.
I tested this PR and noticed the updates wont work. This func needs changes still.
There was a problem hiding this comment.
@uniemimu this works now: tested CR creation without initImage, then added initImage (reconcile OK) and finally removed initImage (reconcile also OK). Can you move this 'ready for review'
There was a problem hiding this comment.
This is a third plugin that makes use of this function defined in a FPGA-related file. Perhaps makes sense to move it to an internal package.
This adds the initImage field to the custom resource definition and takes it into use. The fpga webhook image validation function is split off into a separate file. Signed-off-by: Ukri Niemimuukko <[email protected]>
4 participants
This adds the initImage field to the custom resource definition
and takes it into use.
Closes: #474
Signed-off-by: Ukri Niemimuukko [email protected]