Prepare 0.26.2 release #1498
Merged
Prepare 0.26.2 release #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikko Ylinen <[email protected]>
setInitContainer() adds "init-sriov-numvfs" to initContainers but uses initcontainerName constant to search where to add the QAT configMap volumeMount. Fix by moving all code to use the const. It was also noticed in the controller logs that setting Pod Volumes is not idempotent but broken DaemonSet gets created: ""intel-device-plugins-manager: Reconciler error "err="DaemonSet.apps \"intel-qat-plugin\" is invalid: spec.template.spec.volumes[6].name: Duplicate value: \"qat-config\"" controller="qatdeviceplugin" controllerGroup="deviceplugin.intel.com" Finally, change 'qat-config' to 'intel-qat-config-volume' to better describe that it's a volume. Signed-off-by: Mikko Ylinen <[email protected]>
Fixes: intel#1416 Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
tkatila
requested review from
bart0sh,
hj-johannes-lee,
kad,
mythi and
ozhuraki
as code owners
Codecov Report
@@ Coverage Diff @@
## release-0.26 #1498 +/- ##
================================================
- Coverage 50.89% 50.70% -0.20%
================================================
Files 44 44
Lines 4985 4990 +5
================================================
- Hits 2537 2530 -7
- Misses 2302 2314 +12
Partials 146 146
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
mythi
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.