-
Notifications
You must be signed in to change notification settings - Fork 212
go.mod: update to k8s 1.27.1 and controller runtime 0.15.x #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Go 1.20 changes look straightforward, but "k8s 1.27.0-alpha.1" changes seem to have triggered a lot of errors (which could be documented better). Is this PR still valid? |
It's a draft. Blocked by controller-runtime's client-go changes to get things unblocked. |
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 51.08% 51.08%
=======================================
Files 44 44
Lines 5005 5005
=======================================
Hits 2557 2557
Misses 2302 2302
Partials 146 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
685b46d to
fff8511
Compare
7fecdd4 to
610ad7d
Compare
|
@tkatila @hj-johannes-lee ready for review, PTAL |
k8s 1.27.x triggers build errors on controller-runtime 0.14.x so we will need to update to 0.15.x at the same time. Changes include: * k8s e2e framework moved to use Ginkgo context so we add test context to all our test nodes. * adapt Ginkgo parameter modifications. * adapt SGX admissionwebhook to InjectDecoder removal. * adapt deviceplugins and FPGA CRDs to controller-runtime API changes. Signed-off-by: Mikko Ylinen <[email protected]>
|
the failing test is not related to this pr, right? |
We have suffered from intermitted lockups on GNR targets. This masked results from e2e-dlb and a broken setup was merged. The right fix is to do maintenance on the GNR targets but until that happens, just disable e2e-dlb. Signed-off-by: Mikko Ylinen <[email protected]>
Fixes: #1249
k8s 1.27.x triggers build errors on controller-runtime 0.14.x
so we will need to update to 0.15.x at the same time.
Changes include:
test context to all our test nodes.
API changes.