Skip to content

Conversation

@mythi
Copy link
Contributor

@mythi mythi commented Feb 3, 2023

Fixes: #1249

k8s 1.27.x triggers build errors on controller-runtime 0.14.x
so we will need to update to 0.15.x at the same time.

Changes include:

  • k8s e2e framework moved to use Ginkgo context so we add
    test context to all our test nodes.
  • adapt Ginkgo parameter modifications.
  • adapt SGX admissionwebhook to InjectDecoder removal.
  • adapt deviceplugins and FPGA CRDs to controller-runtime
    API changes.

@eero-t
Copy link
Contributor

eero-t commented Feb 8, 2023

Go 1.20 changes look straightforward, but "k8s 1.27.0-alpha.1" changes seem to have triggered a lot of errors (which could be documented better). Is this PR still valid?

@mythi
Copy link
Contributor Author

mythi commented Feb 8, 2023

Go 1.20 changes look straightforward, but "k8s 1.27.0-alpha.1" changes seem to have triggered a lot of errors (which could be documented better). Is this PR still valid?

It's a draft. Blocked by controller-runtime's client-go changes to get things unblocked.

@mythi mythi changed the title updates work to k8s 1.27 Apr 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #1323 (98c5fb2) into main (adbb6fe) will not change coverage.
The diff coverage is n/a.

❗ Current head 98c5fb2 differs from pull request most recent head 792da69. Consider uploading reports for the commit 792da69 to get more accurate results

@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   51.08%   51.08%           
=======================================
  Files          44       44           
  Lines        5005     5005           
=======================================
  Hits         2557     2557           
  Misses       2302     2302           
  Partials      146      146           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mythi mythi force-pushed the PR-2023-008 branch 3 times, most recently from 685b46d to fff8511 Compare April 20, 2023 05:54
@tkatila tkatila added this to the 0.27.0 milestone Apr 25, 2023
@mythi mythi force-pushed the PR-2023-008 branch 3 times, most recently from 7fecdd4 to 610ad7d Compare May 9, 2023 04:25
@mythi mythi marked this pull request as ready for review May 9, 2023 04:25
@mythi mythi changed the title work to k8s 1.27 go.mod: update to k8s 1.27.1 and controller runtime 0.15.x May 9, 2023
@mythi
Copy link
Contributor Author

mythi commented May 9, 2023

@tkatila @hj-johannes-lee ready for review, PTAL

k8s 1.27.x triggers build errors on controller-runtime 0.14.x
so we will need to update to 0.15.x at the same time.

Changes include:

* k8s e2e framework moved to use Ginkgo context so we add
  test context to all our test nodes.
* adapt Ginkgo parameter modifications.
* adapt SGX admissionwebhook to InjectDecoder removal.
* adapt deviceplugins and FPGA CRDs to controller-runtime
  API changes.

Signed-off-by: Mikko Ylinen <[email protected]>
@hj-johannes-lee
Copy link
Contributor

the failing test is not related to this pr, right?

We have suffered from intermitted lockups on GNR targets. This
masked results from e2e-dlb and a broken setup was merged.

The right fix is to do maintenance on the GNR targets but until
that happens, just disable e2e-dlb.

Signed-off-by: Mikko Ylinen <[email protected]>
@mythi mythi merged commit 6a4721b into intel:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ginkgo upgrade fails

5 participants