-
Notifications
You must be signed in to change notification settings - Fork 212
assorted fixes #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assorted fixes #1299
Conversation
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1299 +/- ##
=======================================
Coverage 51.17% 51.17%
=======================================
Files 44 44
Lines 4879 4879
=======================================
Hits 2497 2497
Misses 2239 2239
Partials 143 143 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| if err = e2epod.WaitForPodsRunningReady(c, "node-feature-discovery", 2, 0, | ||
| 100*time.Second, map[string]string{}); err != nil { | ||
| 200*time.Second, map[string]string{}); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using proxy/mirror didn't fully fix the e2e issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm preparing for another change that makes the spr/gnr instances to run a bit slower.
tkatila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bart0sh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixes: #1284
Fixes: #1277